🍒[cxx-interop] Lower iOS deployment target for Cxx and CxxStdlib #77930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Xazax-hun
approved these changes
Dec 3, 2024
DougGregor
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The iOS/watchOS/tvOS deployment targets for Cxx and CxxStdlib binaries got unintentionally bumped in b87b263, which is causing build failures when trying to back-deploy Swift libraries. This reverts the deployment targets to the older versions.
Scope: Changes the CMake build script for Cxx and CxxStdlib targets.
Risk: Low, this only affects two C++ interop overlay modules, and it only brings back the pre-6.0.2 behavior.
Issue: rdar://140823785 / resolves #77909
Reviewer: @DougGregor @Xazax-hun @drodriguez
Original PR: #77921